[DashboardBundle] Deprecated service container usage in dashboard com… #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deZinc
commented
Jun 15, 2018
•
deZinc
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Fixed tickets |
ProfessorKuma
previously requested changes
Jun 15, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- It seems that our checklist is missing or incomplete
Numkil
approved these changes
Jul 31, 2018
Devolicious
approved these changes
Aug 28, 2018
ProfessorKuma
suggested changes
Aug 28, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR needs some changes
- This PR seems to need a milestone of a minor release.
ProfessorKuma
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
Hi @deZinc, your PR passed all our requirements.
Thank you for contributing!
acrobat
reviewed
Aug 28, 2018
UPGRADE-5.1.md
Outdated
| DashboardBundle | ||
| --------------- | ||
|
|
||
| * Injecting the container in the `DashboardCommand` is deprecated and will be removed in 6.0. Inject the required parameters instead. |
There was a problem hiding this comment.
The upgrade log should be more like this, as the current message is not correct (the container is not injected in the commands, first argument is actually an optional command name)
`XXXXCommand::__construct()` now takes an instance of `XXXX` as the first argument. Not passing it is deprecated and will throw a `TypeError` in 6.0.
Same for the other upgrade notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.