Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[composer] readd swiftmailer bundle #2062

Merged
merged 1 commit into from Aug 1, 2018
Merged

[composer] readd swiftmailer bundle #2062

merged 1 commit into from Aug 1, 2018

Conversation

Numkil
Copy link
Contributor

@Numkil Numkil commented Jul 31, 2018 •
edited

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

ProfessorKuma
ProfessorKuma suggested changes Jul 31, 2018
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Numkil, your PR needs some changes

  • It seems that you should have submitted to the latest minor branch.
  • This PR seems to need a milestone of a patch release.

@ProfessorKuma ProfessorKuma added this to the 5.0.8 milestone Jul 31, 2018
ProfessorKuma
ProfessorKuma suggested changes Jul 31, 2018
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Numkil, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

@Numkil Numkil modified the milestones: 5.0.8, 5.1.0 Jul 31, 2018
ProfessorKuma
ProfessorKuma approved these changes Jul 31, 2018
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Numkil, your PR passed all our requirements.

Thank you for contributing!

@Numkil Numkil merged commit 02fd494 into Kunstmaan:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Priority: High Profile: Backend Type: Bugfix
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Numkil @acrobat @ProfessorKuma