Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MediaBundle] Liip imagine bundle version 2 support #2098

Merged
merged 1 commit into from Dec 4, 2018

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 6, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

Only merge after #2090. Ping me after merge to rebase this PR

Diff best viewed against the prepare-5.2 branch prepare-5.2-php-changes...liip-imagine-bundle-2-support.

#2090 is merged, rebase done.

This PR upgrades the liip/imagine-bundle to version 2, as this is the first version that supports sf4. All custom overrides made in the kunstmaan/media-bundle are ported to the new version.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat added this to In progress in Symfony 4 support Sep 6, 2018
@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from a816f00 to 81f3233 Compare September 6, 2018 14:59
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from 81f3233 to 8e57f72 Compare September 6, 2018 15:06
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from 8e57f72 to 5341384 Compare September 6, 2018 15:07
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from 5341384 to d45746a Compare September 7, 2018 08:53
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from d45746a to f3e7780 Compare November 30, 2018 11:51
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from f3e7780 to 9f21f5e Compare December 2, 2018 08:48
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the liip-imagine-bundle-2-support branch from 9f21f5e to c7c9576 Compare December 3, 2018 14:43
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@sandergo90 sandergo90 merged commit 9684f5c into Kunstmaan:master Dec 4, 2018
Symfony 4 support automation moved this from In progress to Done Dec 4, 2018
@acrobat acrobat deleted the liip-imagine-bundle-2-support branch December 4, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants