New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MediaBundle] Liip imagine bundle version 2 support #2098
[MediaBundle] Liip imagine bundle version 2 support #2098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
a816f00
to
81f3233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
81f3233
to
8e57f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
8e57f72
to
5341384
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
5341384
to
d45746a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
d45746a
to
f3e7780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
f3e7780
to
9f21f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
9f21f5e
to
c7c9576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
Only merge after #2090. Ping me after merge to rebase this PRDiff best viewed against the prepare-5.2 branch prepare-5.2-php-changes...liip-imagine-bundle-2-support.#2090 is merged, rebase done.
This PR upgrades the liip/imagine-bundle to version 2, as this is the first version that supports sf4. All custom overrides made in the kunstmaan/media-bundle are ported to the new version.