[FormBundle] [Tests] Fix namespace + modernize old fashioned mocks and use codeception #2107
Conversation
There was a problem hiding this comment.
Hi @Numkil, your PR needs some changes
- It seems that our checklist is missing or incomplete
There was a problem hiding this comment.
Hi @Numkil, your PR needs some changes
- This PR seems to need a milestone of a minor release.
There was a problem hiding this comment.
Hi @Numkil, your PR passed all our requirements.
Thank you for contributing!
There was a problem hiding this comment.
Hi @Numkil, your PR passed all our requirements.
Thank you for contributing!
|
@Numkil with the new |
|
Imo the namespaces are now fine as they are. The unit directory doesn't impact the functionality of the tests. It only causes problems for when you want to create new classes in this directory and call them with "new" in the tests. This is something that i think should be avoided anyway so not an issue in my eyes. |
* 'master' of github.com:Kunstmaan/KunstmaanBundlesCMS: [MediaBundle] Added image sizes to media chooser (Kunstmaan#2158) [AdminBundle][AdminListBundle] [Tests] fix namespace tests and refactor mocks (Kunstmaan#2108) [NodeBundle] [tests] fix tests namespace and refactor mocks (Kunstmaan#2132) [GeneratorBundle] [tests] fix namespace tests (Kunstmaan#2114) [ConfigBundle] [tests] fix namespace tests (Kunstmaan#2111) [ArticleBundle] fix tests namespace (Kunstmaan#2109) [GeneratorBundle, FormBundle]: add generator for form pageparts (Kunstmaan#2106) [FormBundle] Fix namespace + modernize old fashioned mocks and use codeception (Kunstmaan#2107) [BehatBundle] [Tests] fix namespace tests (Kunstmaan#2110) [DashboardBundle] [Tests] fix namespace tests (Kunstmaan#2112) [FixturesBundle] [tests] fix namespace tests (Kunstmaan#2113) [LeadGenerationBundle] [Tests] fix namespace tests (Kunstmaan#2127) [MediaBundle] [tests] fix namespace tests (Kunstmaan#2128) [MediaPagePartBundle] [tests] fix namespace tests (Kunstmaan#2129) [MenuBundle] [Tests] fix tests namespace (Kunstmaan#2130) [MultiDomainBundle] [tests] fix namespace tests (Kunstmaan#2131)
This fixes the issue where codeception could not run individual test classes for this bundle. Also gets rid of some old fashioned mocks that were causing namespace issues.