[MediaBundle] Folder types as constants #2124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Sep 13, 2018
There was a problem hiding this comment.
Hi @SpadXIII, your PR needs some changes
- It seems that you should have submitted to master.
- This PR seems to need a milestone of a minor release.
- your PR title should look like
[SomeBundle] Fixed some code
SpadXIII
changed the title
|
Someday I'll get it right the first time... will start over again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a difference between the FolderType rel-field and the ones added in the fixtures. Extracted all used values into a class with constants.
ps. I'm not sure why, but it's showing a change in fields.html.twig (src/Kunstmaan/AdminBundle/Resources/views/Form/fields.html.twig) again, while that's a change already merged into 5.0 ?