[AdminBundle][AdminListBundle] Revert code changes for container access deprecation to make symfony 4 upgrade easier #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Oct 21, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR needs some changes
- your PR title should look like
[SomeBundle] Fixed some code
ProfessorKuma
suggested changes
Oct 21, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR needs some changes
- your PR title should look like
[SomeBundle] Fixed some code
ProfessorKuma
suggested changes
Oct 21, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR needs some changes
- your PR title should look like
[SomeBundle] Fixed some code
ProfessorKuma
suggested changes
Oct 21, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR needs some changes
- your PR title should look like
[SomeBundle] Fixed some code
ProfessorKuma
suggested changes
Oct 21, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR needs some changes
- your PR title should look like
[SomeBundle] Fixed some code
acrobat
changed the title
ProfessorKuma
approved these changes
Oct 21, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
diskwriter
added a commit
to diskwriter/KunstmaanBundlesCMS
that referenced
this pull request
Nov 19, 2018
* 'master' of github.com:Kunstmaan/KunstmaanBundlesCMS: [NodeSearchBundle][Tests] fix namespace tests (Kunstmaan#2136) [PagePartBundle][Tests] fix namespace tests and remove old mocks (Kunstmaan#2137) [RedirectBundle][Tests] fix namespace tests (Kunstmaan#2138) [SearchBundle][Tests] fix namespace tests (Kunstmaan#2139) [SeoBundle][Tests] fix namespace tests (Kunstmaan#2140) [SitemapBundle][Tests] fix namespace tests (Kunstmaan#2141) [TaggingBundle] [Tests] fix namespace tests (Kunstmaan#2142) [TranslatorBundle][Tests] fix namespace tests (Kunstmaan#2144) [UsermanagementBundle] [Tests] fix namespace tests (Kunstmaan#2145) [UtilitiesBundle][Tests] fix namespace tests and old mocks (Kunstmaan#2146) [VotingBundle] [Test] fix namespace tests (Kunstmaan#2147) Revert code changes for container access deprecation to make symfony 4 upgrade easier (Kunstmaan#2167) [MediaBundle] Folder types as constants (part 2) (Kunstmaan#2150) [MediaBundle] Folder types as constants (Kunstmaan#2125) [DashboardBundle] Fixed duplicate service id and missing command in command services config (Kunstmaan#2121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method we override here is an internal method so it has changes from 3.4 -> 4.0. This makes it currently hard to support both versions without BC breaks. So I suggest to revert this deprecation warning for now (until we can come up with a better fix). We currently have a notice about removing container access in these controller in our upgrade guide so this will do for now.