[ConfigBundle] Remove route service annotation as default route is already provided as service #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR needs some changes
- This PR seems to need a milestone of a minor release.
ProfessorKuma
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
acrobat
added
Priority: Normal
Target audience: Developers
Profile: Backend
and removed
Type: Feature
labels
acrobat
force-pushed
the
fix-service-route-annotation
branch
from
9d755db
to
5d1fcf4
Compare
…ready provided as service
acrobat
force-pushed
the
fix-service-route-annotation
branch
from
5d1fcf4
to
a73935a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup pr of #2184 and fix for build error detected in Kunstmaan/KunstmaanBundlesStandardEdition#268