Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] Improve twig template deprecations #2207

Merged
merged 1 commit into from Jan 4, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Dec 27, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

Use the new twig {% deprecated %} tag to improve the template deprecations we did in 5.1

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@sandergo90 sandergo90 merged commit b71e049 into Kunstmaan:master Jan 4, 2019
@acrobat acrobat deleted the improve-twig-deprecations branch January 4, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants