Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeneratorBundle] Sf4 support for generate layout #2223

Merged
merged 1 commit into from Jan 14, 2019
Merged

[GeneratorBundle] Sf4 support for generate layout #2223

merged 1 commit into from Jan 14, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jan 13, 2019 •
edited

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

PR must be rebased after #2218 is merged

Code changes for both sf3.4/sf4 support in the layout generator

@acrobat acrobat added this to the 5.2.0 milestone Jan 13, 2019
ProfessorKuma
ProfessorKuma approved these changes Jan 13, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat added this to In progress in Symfony 4 support Jan 13, 2019
@jockri jockri merged commit 93c1115 into Kunstmaan:master Jan 14, 2019
Symfony 4 support automation moved this from In progress to Done Jan 14, 2019
@acrobat acrobat mentioned this pull request Jan 14, 2019
Merged
@acrobat acrobat deleted the sf4-layout-generator branch January 14, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Priority: Normal Profile: Backend sf4-compatibility Target audience: Developers
Projects
No open projects
Symfony 4 support
  
Done
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acrobat @ProfessorKuma @jockri