Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeBundle] Mark node version lock helper service as public #2246

Merged
merged 1 commit into from Jan 22, 2019
Merged

[NodeBundle] Mark node version lock helper service as public #2246

merged 1 commit into from Jan 22, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jan 21, 2019

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

This service is used in the node admin controller

@acrobat acrobat added this to the 5.2.0 milestone Jan 21, 2019
ProfessorKuma
ProfessorKuma approved these changes Jan 21, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat added this to In progress in Symfony 4 support Jan 21, 2019
@acrobat acrobat merged commit a419f23 into Kunstmaan:master Jan 22, 2019
Symfony 4 support automation moved this from In progress to Done Jan 22, 2019
@acrobat acrobat deleted the lock-helper-service-public branch January 22, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Priority: Normal Profile: Backend sf4-compatibility Target audience: Developers
Projects
No open projects
Symfony 4 support
  
Done
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acrobat @ProfessorKuma