[AdminListBundle] upgraded dev requirements #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 30, 2019 14:58
… should be refactored so these can be removed
ProfessorKuma
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
Hi @deZinc, your PR passed all our requirements.
Thank you for contributing!
acrobat
approved these changes
Jan 31, 2019
deZinc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until all bundles have been upgraded and use the same dev dependencies.
Extra kuma bundles were added as dev dependencies. The tests need to be refactored in the future so these can be removed. See #2292 where this refactoring has been started