Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArticleBundle] upgraded dev requirements #2298

Merged

Conversation

deZinc
Copy link
Contributor

@deZinc deZinc commented Jan 31, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

WIP until all bundles have been upgraded and use the same dev dependencies.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deZinc, your PR needs some changes

  • your PR title should look like [SomeBundle] Fixed some code

@deZinc deZinc changed the title Feature/articlebundle update dev [ArticleBundle] upgraded dev requirements Jan 31, 2019
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deZinc, your PR passed all our requirements.

Thank you for contributing!

@deZinc deZinc changed the title [ArticleBundle] upgraded dev requirements [WIP][ArticleBundle] upgraded dev requirements Jan 31, 2019
@deZinc deZinc changed the title [WIP][ArticleBundle] upgraded dev requirements [ArticleBundle] upgraded dev requirements Feb 1, 2019
@sandergo90 sandergo90 merged commit 10a5db7 into Kunstmaan:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants