New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MediaBundle,GeneratorBundle] Added validation options (mimetypes, min/max width/height for images) to media objects in the backend. #230

Merged
merged 7 commits into from Apr 1, 2015

Conversation

Projects
None yet
3 participants
@arneruy
Copy link
Contributor

arneruy commented Mar 30, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #41

Added validation options (mimetypes, min/max width/height for images) to media objects in the backend.

validation

KUNSTMAAN added some commits Mar 30, 2015

@roderik

This comment has been minimized.

Copy link
Contributor

roderik commented Mar 30, 2015

@arneruy please follow this soon to be released contribution guidelines for your pull request: https://github.com/roderik/KunstmaanBundlesCMS/blob/master/docs/06-02-pull-requests.md

* Convert the limit to the smallest possible number
* (i.e. try "MB", then "kB", then "bytes")
*/
private function factorizeSizes($size, $limit, $binaryFormat)

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

is this method really used?

@@ -11,8 +11,8 @@
*
* @ORM\Entity(repositoryClass="Kunstmaan\MediaBundle\Repository\MediaRepository")
* @ORM\Table(name="kuma_media", indexes={
* @ORM\Index(name="idx_media_name", columns={"name"}),
* @ORM\Index(name="idx_media_deleted", columns={"deleted"})
* @ORM\Index(name="idx_name", columns={"name"}),

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

I think this went wrong in a merge conflict? it should be idx_media_name and idx_media_deleted because of 07768d0

@@ -95,7 +96,7 @@ private function generatePagePartEntity()
$this->assistant->writeLine('Generating entity : <info>OK</info>');
}

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

don't do code formatting of old code in a feature PR, also think that there should not be spaces here

@@ -8,6 +8,7 @@
use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\HttpKernel\Bundle\BundleInterface;
use Symfony\Component\Yaml\Yaml;
use Kunstmaan\GeneratorBundle\Helper\GeneratorUtils;

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

you added an unneeded use ?

@@ -203,6 +203,7 @@ protected function generateEntityAdminType(
*
* @param BundleInterface $bundle
*/

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

don't do code formatting of old code in a feature PR, also think that there should not be spaces here

@@ -403,7 +404,6 @@ public function renderTwigFile($template, $target, array $parameters, $sourceDir
if (!is_dir(dirname($target))) {
mkdir(dirname($target), 0777, true);
}

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

don't do code formatting of old code in a feature PR

@@ -711,7 +762,7 @@ protected function getEntityFields(
);
break;
}

This comment has been minimized.

@krispypen

krispypen Mar 31, 2015

Member

don't do code formatting of old code in a feature PR

arneruy added some commits Mar 31, 2015

krispypen added a commit that referenced this pull request Apr 1, 2015

@krispypen krispypen merged commit 8ab6fb9 into Kunstmaan:master Apr 1, 2015

2 checks passed

Scrutinizer 14 new issues, 6 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roderik roderik changed the title Feature/mediavalidation [MediaBundle,GeneratorBundle] Added validation options (mimetypes, min/max width/height for images) to media objects in the backend. Apr 7, 2015

@roderik roderik modified the milestone: 3.1.0 Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment