[FormBundle] Deprecate service class parameters #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
deZinc
approved these changes
Feb 1, 2019
acrobat
added a commit
to acrobat/KunstmaanBundlesCMS
that referenced
this pull request
Feb 8, 2019
* master: (108 commits) [AllBundles] Fix sf4 rootNode deprecation (Kunstmaan#2337) [TranslatorBundle] Deprecated the MigrationsDiffCommand & DiffCommand (Kunstmaan#2341) [NodeSearchBundle] Deprecate container access in NodeIndexUpdateEventListener (Kunstmaan#2279) [SeoBundle] Added option to provide cache for og image dimension calls (Kunstmaan#2313) [MenuBundle] Mark menu service as public [SearchBundle] Make search analysis service public for kuma:search:setup command (Kunstmaan#2336) [AllBundles] Test latest symfony and supported lts (Kunstmaan#2333) [DashboardBundle] Move google api parameters to dashboard bundle config instead of parameters (Kunstmaan#2280) [SearchBundle] Don't require value if we provide a default value [AdminBundle] Use new admin bundle parameters instead of the old deprecated [AdminListBundle] added getViewUrl to adminlist config. interface [TranslatorBundle] Speed up bulk import of large translation files (Kunstmaan#2264) [SearchBundle] Move searchindexprefix parameter to search bundle config instead of parameter (Kunstmaan#2281) [AdminBundle] Move admin locale parameters to admin_bundle config instead of parameters (Kunstmaan#2273) [SearchBundle] Move search parameters to search_bundle config instead of parameters (Kunstmaan#2276) [MediaBundle] Move aviary_api_key parameter to media bundle config instead of parameter (Kunstmaan#2284) [MediaPagePartBundle] Fixed last remaining extend of old phpunit testcase class [AdminListBundle] refactored/simplified AdminListTest [FormBundle] Deprecate service class parameters (Kunstmaan#2303) [ConfigBundle] Deprecate service class parameters (Kunstmaan#2306) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate service class parameters to override the class of the service definition