Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VotingBundle] upgraded dev dependencies #2318

Merged
merged 1 commit into from Feb 1, 2019
Merged

[VotingBundle] upgraded dev dependencies #2318

merged 1 commit into from Feb 1, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jan 31, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

WIP until all bundles have been upgraded and use the same dev dependencies.

@acrobat acrobat added this to the 5.2.0 milestone Jan 31, 2019
ProfessorKuma
ProfessorKuma approved these changes Jan 31, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acrobat, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat changed the title [WIP][VotingBundle] upgraded dev dependencies [VotingBundle] upgraded dev dependencies Feb 1, 2019
@sandergo90 sandergo90 merged commit d2beec9 into Kunstmaan:master Feb 1, 2019
@acrobat acrobat deleted the votingbundle-upgrade-dev branch February 1, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deZinc deZinc deZinc approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Priority: Normal Profile: Backend
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acrobat @deZinc @ProfessorKuma @sandergo90