[GeneratorBundle] Fixed Page(part) generating

[jeroenjans]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets

This PR fixes some problems when generating a Page(part).

The error that was reported was:

In ExtraFunctions.php line 26:
                                                                                                    
  Impossible to invoke a method ("getName") on a string variable ("TestWebsiteBundle").  

And

In ExtraFunctions.php line 8:
                                                                                                                                                                                                           
  An exception has been thrown during the rendering of a template ("Catchable Fatal Error: Object of class Test\WebsiteBundle\TestWebsiteBundle could not be converted to string").  
                                                                                                                                                                                                           

In Environment.php(378) : eval()'d code line 33:
                                                                                                                                      
  Catchable Fatal Error: Object of class Test\WebsiteBundle\TestWebsiteBundle could not be converted to string  

Another possible solution would be to modify the Entity/Pages/ExtraFunctions.php file so that it's using {{ bundle }} instead of {{ bundle.getName() }}.
If this is the desired fix then let me know and I'll change the PR accordingly.

[ProfessorKuma]

Hi @jeroenjans, your PR needs some changes

• It seems that you should have submitted to the latest minor branch.
• This PR seems to need a milestone of a patch release.

[acrobat]

Hi @jeroenjans,

Thanks for this bugfix! This bug was caused by changes in PR #2235. There was a incorrect change for sf4 made. The correct fix would to change the check in the ExtraFunction.php from

{% if not isV4 %}{{ bundle.getName() }}:{%endif%}

To

{% if not isV4 %}{{ bundle }}:{%endif%}

Can you update your pr to revert to current fix and implement the suggested fix in ExtraFunctions.php? Thanks!

[jeroenjans]

Hey @acrobat,

I've updated the PR according to the feedback.
Let me know if I need to change anything else!

OK

[acrobat]

Thanks @jeroenjans!