Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] Fix SF 4.3 error in Role class #2504

Closed
wants to merge 1 commit into from
Closed

Conversation

jockri
Copy link
Contributor

@jockri jockri commented Jun 15, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

Make sure the __toString function is matching the format of the parent class. This is needed to prevent errors when running symfony 4.3. This is backwards compatible with older symfony versions.

@ProfessorKuma ProfessorKuma added this to the 5.3.2 milestone Jun 15, 2019
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a patch release.
  • your PR title should look like [SomeBundle] Fixed some code

@jockri jockri changed the title Fix SF 4.3 error in Role class [AdminBundle] Fix SF 4.3 error in Role class Jun 15, 2019
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@Devolicious
Copy link
Contributor

duplicate of #2493

@Devolicious Devolicious closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants