Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminListBundle] Fixed undefined entity when creating entity having itemActions #2530

Merged
merged 1 commit into from Jul 26, 2019

Conversation

JZuidema
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

When an admin list has custom item actions (by defining getItemActions() in admin list configurator), you can not add an entity anymore. This is because both add and edit actions use the same template (Kunstmaan/AdminListBundle/Resources/views/Default/add_or_edit.html.twig).
However, only the edit action passes the entity variable. So when using the add action, it causes an error

@ProfessorKuma ProfessorKuma added this to the 5.3.3 milestone Jul 23, 2019
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a patch release.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat
Copy link
Member

acrobat commented Jul 26, 2019

Thanks @JZuidema!

@acrobat acrobat merged commit 0c8d201 into Kunstmaan:5.3 Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants