Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeBundle] Fix translation typos #2537

Merged
merged 1 commit into from Aug 9, 2019
Merged

[NodeBundle] Fix translation typos #2537

merged 1 commit into from Aug 9, 2019

Conversation

poveu
Copy link
Contributor

@poveu poveu commented Aug 2, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

@ProfessorKuma ProfessorKuma added this to the 5.3.3 milestone Aug 2, 2019
ProfessorKuma
ProfessorKuma suggested changes Aug 2, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a patch release.

ProfessorKuma
ProfessorKuma approved these changes Aug 2, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@poveu poveu mentioned this pull request Aug 2, 2019
Closed
@acrobat
Copy link
Member

acrobat commented Aug 9, 2019

Thanks @poveu!

@acrobat acrobat merged commit 0199367 into Kunstmaan:5.3 Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Bugfix
Projects
None yet
Milestone
5.3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poveu @acrobat @ProfessorKuma