Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] Revert "rewrite method in aclhelpers to fix deprecation message" #2552

Merged
merged 1 commit into from Sep 12, 2019
Merged

[AdminBundle] Revert "rewrite method in aclhelpers to fix deprecation message" #2552

merged 1 commit into from Sep 12, 2019

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 12, 2019

Reverts #2539

@acrobat acrobat added this to the 5.3.4 milestone Sep 12, 2019
ProfessorKuma
ProfessorKuma suggested changes Sep 12, 2019
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that our checklist is missing or incomplete

@acrobat acrobat merged commit be4e1d3 into 5.3 Sep 12, 2019
@acrobat acrobat deleted the revert-2539-feature/fixUserRoleDeprecation branch September 12, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma requested changes

Assignees
No one assigned
Labels
Type: BC break
Projects
None yet
Milestone
5.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acrobat @ProfessorKuma