Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaBundle] Fix typo in template path #2607

Merged
merged 1 commit into from Jan 7, 2020
Merged

[MediaBundle] Fix typo in template path #2607

merged 1 commit into from Jan 7, 2020

Conversation

Numkil
Copy link
Contributor

@Numkil Numkil commented Jan 6, 2020

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

ProfessorKuma
ProfessorKuma suggested changes Jan 6, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

@ProfessorKuma ProfessorKuma added this to the 5.4.0 milestone Jan 6, 2020
ProfessorKuma
ProfessorKuma approved these changes Jan 6, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat
Copy link
Member

acrobat commented Jan 7, 2020

Good catch, thanks!

@acrobat acrobat merged commit 9a2f6dd into Kunstmaan:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Bugfix Type: Feature
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Numkil @acrobat @ProfessorKuma