Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeneratorBundle] Fix incorrect return types in generated classes #2641

Merged
merged 1 commit into from
Mar 4, 2020
Merged

[GeneratorBundle] Fix incorrect return types in generated classes #2641

merged 1 commit into from
Mar 4, 2020

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Mar 4, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

Fixed incorrect returntypes introduced in #2549

@acrobat acrobat added this to the 5.4.3 milestone Mar 4, 2020
@acrobat acrobat requested a review from Devolicious March 4, 2020 12:45
ProfessorKuma
ProfessorKuma previously requested changes Mar 4, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to the latest minor branch.

@acrobat acrobat dismissed ProfessorKuma’s stale review March 4, 2020 12:46

Referenced PR was merged in v5.4

@acrobat acrobat merged commit b15e047 into Kunstmaan:5.4 Mar 4, 2020
@acrobat acrobat deleted the fix-generator-typehints branch March 4, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma left review comments

@Devolicious Devolicious Awaiting requested review from Devolicious

Assignees
No one assigned
Labels
Type: Bugfix
Projects
None yet
Milestone
5.4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acrobat @ProfessorKuma