Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaBundle] Fix liip/imagine controller deprecation #2740

Merged
merged 1 commit into from Sep 16, 2020
Merged

[MediaBundle] Fix liip/imagine controller deprecation #2740

merged 1 commit into from Sep 16, 2020

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 11, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #2726

@acrobat acrobat added this to the 5.7.0 milestone Sep 11, 2020
ProfessorKuma
ProfessorKuma approved these changes Sep 11, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the fix-liip-imagine-controller-deprecation branch from 7d0693b to 3c34e4a Compare September 16, 2020 06:33
@acrobat acrobat merged commit 9e3e67c into Kunstmaan:master Sep 16, 2020
@acrobat acrobat deleted the fix-liip-imagine-controller-deprecation branch September 16, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyvw dannyvw dannyvw approved these changes

@Numkil Numkil Numkil approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

[MediaBundle] ImagineController deprecation
4 participants
@acrobat @dannyvw @Numkil @ProfessorKuma