Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] Prepare code to remove deprecated doctrine/cache and replace with symfony/cache #2751

Merged
merged 1 commit into from
Oct 28, 2020
Merged

[AdminBundle] Prepare code to remove deprecated doctrine/cache and replace with symfony/cache #2751

merged 1 commit into from
Oct 28, 2020

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 17, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets

The doctrine/cache-bundle is deprecated for symfony 5 and the usage of symfony/cache is advised

@acrobat acrobat added this to the 5.7.0 milestone Sep 17, 2020
@acrobat acrobat added this to In progress in Symfony 5 support via automation Sep 17, 2020
ProfessorKuma
ProfessorKuma approved these changes Sep 17, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat force-pushed the deprecate-doctrine-cache-usage branch 9 times, most recently from 03a9157 to c2d0b9e Compare September 20, 2020 19:39
@acrobat acrobat force-pushed the deprecate-doctrine-cache-usage branch from c2d0b9e to 1047d0e Compare October 2, 2020 13:19
@acrobat acrobat force-pushed the deprecate-doctrine-cache-usage branch 2 times, most recently from ad621bb to 3d3f83b Compare October 27, 2020 14:49
@acrobat acrobat force-pushed the deprecate-doctrine-cache-usage branch from 3d3f83b to 3267a2a Compare October 27, 2020 14:50
@acrobat acrobat merged commit dc75ece into Kunstmaan:master Oct 28, 2020
Symfony 5 support automation moved this from In progress to Done Oct 28, 2020
@acrobat acrobat deleted the deprecate-doctrine-cache-usage branch October 28, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Deprecation
Projects
No open projects
Symfony 5 support
  
Done
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acrobat @ProfessorKuma