Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] Bump knplabs/knp-menu-bundle and remove default config #2756

Merged
merged 1 commit into from Oct 2, 2020
Merged

[AdminBundle] Bump knplabs/knp-menu-bundle and remove default config #2756

merged 1 commit into from Oct 2, 2020

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Sep 21, 2020 •
edited

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

The config we set in the admin extension is equal to the default config. Prepare code to support symfony 5

Needs rebase after #2748 to make the builds pass

@acrobat acrobat added this to the 5.7.0 milestone Sep 21, 2020
@acrobat acrobat added this to In progress in Symfony 5 support via automation Sep 21, 2020
ProfessorKuma
ProfessorKuma approved these changes Sep 21, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat merged commit 0ffb73e into Kunstmaan:master Oct 2, 2020
Symfony 5 support automation moved this from In progress to Done Oct 2, 2020
@acrobat acrobat deleted the bump-knp-menubundle branch October 2, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Improvement
Projects
No open projects
Symfony 5 support
  
Done
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acrobat @ProfessorKuma