Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] Add brands to font awesome imports #2759

Merged
merged 1 commit into from Sep 21, 2020
Merged

[AdminBundle] Add brands to font awesome imports #2759

merged 1 commit into from Sep 21, 2020

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Sep 21, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2733

ProfessorKuma
ProfessorKuma suggested changes Sep 21, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to the latest minor branch.
  • This PR seems to need a milestone of a patch release.
  • your PR title should look like [SomeBundle] Fixed some code

@ProfessorKuma ProfessorKuma added this to the 5.5.6 milestone Sep 21, 2020
@dannyvw dannyvw changed the title Add brands to font awesome imports [AdminBundle] Add brands to font awesome imports Sep 21, 2020
@acrobat
Copy link
Member

acrobat commented Sep 21, 2020

@dannyvw can you rebase this PR against the 5.5 branch? Thanks!

@dannyvw dannyvw changed the base branch from master to 5.5 September 21, 2020 07:29
@dannyvw
Copy link
Contributor Author

dannyvw commented Sep 21, 2020

@acrobat Done

ProfessorKuma
ProfessorKuma approved these changes Sep 21, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat
Copy link
Member

acrobat commented Sep 21, 2020

Thanks @dannyvw!

@acrobat acrobat merged commit 9cfb47b into Kunstmaan:5.5 Sep 21, 2020
@dannyvw dannyvw deleted the fontawesome branch September 21, 2020 08:35
@acrobat acrobat mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeerten dbeerten dbeerten approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

@FVKVN FVKVN Awaiting requested review from FVKVN

Assignees
No one assigned
Labels
Type: Bugfix
Projects
None yet
Milestone
5.5.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dannyvw @acrobat @dbeerten @ProfessorKuma