Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaBundle] getImageUrl has only 2 params #2772

Merged
merged 1 commit into from Oct 1, 2020
Merged

[MediaBundle] getImageUrl has only 2 params #2772

merged 1 commit into from Oct 1, 2020

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Oct 1, 2020 •
edited by acrobat

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets comma separated list of tickets fixed by the PR

ProfessorKuma
ProfessorKuma suggested changes Oct 1, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to the latest minor branch.
  • This PR seems to need a milestone of a patch release.

@ProfessorKuma ProfessorKuma added this to the 5.5.6 milestone Oct 1, 2020
@acrobat acrobat modified the milestones: 5.5.6, 5.7.0 Oct 1, 2020
ProfessorKuma
ProfessorKuma approved these changes Oct 1, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat merged commit 733d1ea into Kunstmaan:master Oct 1, 2020
@acrobat
Copy link
Member

acrobat commented Oct 1, 2020

Thanks @dannyvw!

@dannyvw dannyvw deleted the imageurl branch October 1, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

@ProfessorKuma ProfessorKuma ProfessorKuma approved these changes

Assignees
No one assigned
Labels
Type: Bugfix Type: Improvement
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dannyvw @acrobat @ProfessorKuma