Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeBundle] Improve performance of NodeMenu class #3046

Merged
merged 1 commit into from
Jan 10, 2022
Merged

[NodeBundle] Improve performance of NodeMenu class #3046

merged 1 commit into from
Jan 10, 2022

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jan 10, 2022 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

Don't call the init() method when it's not necessary, the getBreadCrumb method and other methods depending on this don't need the values from the init(). Diff best viewed with ignoring whitespace changes

On large websites this gives a huge improvement

image

@acrobat acrobat added this to the 5.10.1 milestone Jan 10, 2022
@acrobat acrobat changed the base branch from 5.10 to 5.9 January 10, 2022 14:00
@acrobat acrobat modified the milestones: 5.10.1, 5.9.2 Jan 10, 2022
@acrobat acrobat merged commit e5406b0 into Kunstmaan:5.9 Jan 10, 2022
@acrobat acrobat deleted the improve-node-menu branch January 10, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
5.9.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@acrobat