Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeneratorBundle] finder->in(dir) not ->in(dir/glob) #529

Merged
merged 1 commit into from
Jul 13, 2015
Merged

[GeneratorBundle] finder->in(dir) not ->in(dir/glob) #529

merged 1 commit into from
Jul 13, 2015

Conversation

tarjei
Copy link
Contributor

@tarjei tarjei commented Jul 8, 2015

I got errors when using the PagePart generator:

[InvalidArgumentException]
The "src/Novap/SiteBundle/Entity/Pages/*.php" directory does not exist.

These changes silenced the errors

@tarjei
finder->in(dir) not ->in(dir/glob)
c857823 
I got errors when using the PagePart generator: 

                                                                                                                
  [InvalidArgumentException]                                                                                    
  The "src/Novap/SiteBundle/Entity/Pages/*.php" directory does not exist.  
                                                                                                                
These changes silenced the errors
@roderik roderik changed the title finder->in(dir) not ->in(dir/glob) [GeneratorBundle] finder->in(dir) not ->in(dir/glob) Jul 13, 2015
@roderik roderik added this to the 3.2.1 milestone Jul 13, 2015
roderik pushed a commit that referenced this pull request Jul 13, 2015
Merge pull request #529 from tarjei/patch-1
d7e6be1 
[GeneratorBundle] finder->in(dir) not ->in(dir/glob)
@roderik roderik merged commit d7e6be1 into Kunstmaan:master Jul 13, 2015
@tarjei
Copy link
Contributor Author

tarjei commented Jul 13, 2015

Thanks, I didn't get the time to make a propper pr
13. jul. 2015 16.41 skrev "Roderik van der Veer" notifications@github.com:

Merged #529 #529.

—
Reply to this email directly or view it on GitHub
#529 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: Normal Profile: Backend Target audience: Developers Type: Bugfix
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tarjei @denbatte @roderik