Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminListBundle] Fix pagination issue for DBAL adminlists #532

Merged
merged 1 commit into from
Jul 8, 2015
Merged

[AdminListBundle] Fix pagination issue for DBAL adminlists #532

merged 1 commit into from
Jul 8, 2015

Conversation

jockri
Copy link
Contributor

@jockri jockri commented Jul 8, 2015

The setCurrentPage also checks if the page exists based in the max items per page. So if you override it, it checks if the page exists based on the default max items per page, because the custom number is only set after the setCurrentPage method call.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

@jockri jockri changed the title [AdminListBundle] Fix pagination issue [AdminListBundle] Fix pagination issue for DBAL adminlists Jul 8, 2015
@roderik roderik added this to the 3.2.1 milestone Jul 8, 2015
roderik pushed a commit that referenced this pull request Jul 8, 2015
Merge pull request #532 from jockri/fix-adminlist-dbal-pagination
34217ae 
[AdminListBundle] Fix pagination issue for DBAL adminlists
@roderik roderik merged commit 34217ae into Kunstmaan:master Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: High Profile: Backend Target audience: Administrators Type: Bugfix
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jockri @roderik