Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle, NodeBundle] allow changing nodes parent in sidebar tree #538

Merged
merged 3 commits into from
Jul 14, 2015

Conversation

mlebkowski
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets -

Deprecations:

  • SearchTypeInterface
  • HideFromNodeTreeInterface
  • HasNodeInterface::getPossibleChildTypes()

New featres

  • PagesConfiguration — a service responsible for providing static configuration of page types, such as isIndexable, isStructureNode or possibleChildTypes
  • JsTree icons can now be changed using configuration (see example in documentation)
  • Nodes can be moved outside of their parents in JsTree but only according to possibleChildTypes configuration

Configuration example

kunstmaan_node:
    pages:
        AcmeBundle\Entity\Pages\HomePage:
            name: Home page
            indexable: false
            # font awesome icons:
            icon: fa fa-home
            # hide from sidebar tree in admin panel:
            hidden_from_tree: false
            allowed_children:
                # simple reference:
                - AcmeBundle\Entity\Pages\SearchPage
                # custom reference:
                - name: Custom name
                  class: AcmeBundle\Entity\Pages\ArticlePage

        AcmeBundle\Entity\Pages\ArticlePage:
            # the name is translated by default:
            name: pages.article
            indexable: true
            icon: fa fa-newspaper
            search_type: article

        AcmeBundle\Entity\Pages\SearchPage:
            name: Search results page
            indexable: false
            icon: fa fa-search

@mlebkowski mlebkowski changed the title allow changing nodes parent in sidebar tree [AdminBundle, NodeBundle] allow changing nodes parent in sidebar tree Jul 11, 2015
@roderik
Copy link
Contributor

roderik commented Jul 13, 2015

How does this work with BC compatibility? Does it break anything when i just merge it?

@mlebkowski
Copy link
Contributor Author

@roderik, nope, it’s just deprecations, all existing methods/interfaces will be used as a fallback

@roderik roderik added this to the 3.2.1 milestone Jul 13, 2015
roderik pushed a commit that referenced this pull request Jul 14, 2015
[AdminBundle, NodeBundle] allow changing nodes parent in sidebar tree
@roderik roderik merged commit 7b216e5 into Kunstmaan:master Jul 14, 2015
@mlebkowski mlebkowski deleted the feature/tree-change-parent branch February 4, 2016 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants