[NodeBundle] Re-add the nodemenu again and make it lazy loading #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krispypen
changed the title
| @@ -170,6 +184,7 @@ public function getTopNodes() | |||
| */ | |||
| public function getBreadCrumb() | |||
| { | |||
| $this->init(); | |||
There was a problem hiding this comment.
I don’t think you need to init() the whole menu to get breadcrumbs
no need to do init for the breadcrumb
krispypen
force-pushed
the
feature/bringnodemenuback
branch
from
af9b950
to
61be340
Compare
…menuback Conflicts: src/Kunstmaan/NodeBundle/Helper/NodeMenu.php
roderik
pushed a commit
that referenced
this pull request
Jul 23, 2015
[NodeBundle] Re-add the nodemenu again and make it lazy loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the nodemenu from the rendercontext brought lots of problems in:
My solution:
For the sluglistener-controllerserviceaction the nodemenu was never removed (see SlugSecurityListener L 76) , so these will also become faster since this lazy loading strategy.