[Dependencies] Support for symfony2.7 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u u Workarround for service circular dependencies symfony 2.7 support
krispypen
changed the title
roderik
pushed a commit
that referenced
this pull request
Jul 31, 2015
[Dependencies] Support for symfony2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was:
In Symfony 2.7 the securitycontext is deprecated and logs a deprecation warning that you should use the security.token_storage which is introduced in 2.6. When logging a deprecation warning in the classloader, there was a circular dependency in the services: the logger has a UserProcessor which need the securitycontext but it was already in the classloading process of the securitycontext.
We do not change to the new security.token_storage because otherwise we cannot support symfony2.5 anymore.