[NodeBundle] Removed fallback logic for simple route loaders #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jockri if it's a bc break, you need a mention in the upgrade file |
jockri
force-pushed
the
remove-routeloader-fallbacks
branch
from
a133218
to
92ce047
Compare
|
@roderik documentation added |
roderik
pushed a commit
that referenced
this pull request
Aug 20, 2015
[NodeBundle] Removed fallback logic for simple route loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, it is not possible anymore to use custom route loaders (
LoaderInterface) for defining extra routes that are handled via the controller of aPage. You should use a custom router (RouterInterface) instead. This is a BC break!Example use case:
/video-> VideoOverviewPage with custom controller/video/123-> no page linked tot this url, a custom defined route (/{url}/{videoid}) that is also using the controller of the VideoOverviewPage(as discussed with @kimausloos and @wimvds)