Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SearchBundle] Add the locale to the request context when populating the search index #634

Merged
merged 1 commit into from
Aug 15, 2015

Conversation

jockri
Copy link
Contributor

@jockri jockri commented Aug 14, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

When the search index gets populated, their was no _locale parameter in the RenderContext because the command is executed from the command line. The _locale parameter is in the context for browser requests, so it is also needed when populating the search index.

Example use case:
When you have this peace of code in twig, it works for browser requests, but not when populating the search index.

<a href="{{ path('_slug', { url: nodeTranslation.url }) }}">click here</a>

@krispypen
Copy link
Contributor

@roderik 👍

@roderik roderik added this to the 3.2.5 milestone Aug 15, 2015
roderik pushed a commit that referenced this pull request Aug 15, 2015
[SearchBundle] Add the locale to the request context when populating the search index
@roderik roderik merged commit b279118 into Kunstmaan:master Aug 15, 2015
@roderik roderik modified the milestones: 3.2.5, 3.3.0 Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants