Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PagePartBundle] Make it possible to override the twig template for a custom PagePartWidget #635

Merged
merged 1 commit into from
Aug 18, 2015

Conversation

jockri
Copy link
Contributor

@jockri jockri commented Aug 17, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

@@ -128,11 +128,19 @@ public function getFormErrors(FormView $formView)
}

/**
* @param string $template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add these here?They are already in the FormWidget class that this class inherits from...

@roderik roderik added this to the 3.2.5 milestone Aug 18, 2015
@jockri jockri force-pushed the override-pagepartwidget-template branch from 95081cd to d5ef39e Compare August 18, 2015 07:35
@jockri
Copy link
Contributor Author

jockri commented Aug 18, 2015

@wimvds fixed it

@krispypen
Copy link
Contributor

@roderik 👍

roderik pushed a commit that referenced this pull request Aug 18, 2015
[PagePartBundle] Make it possible to override the twig template for a custom PagePartWidget
@roderik roderik merged commit 728f09e into Kunstmaan:master Aug 18, 2015
@jockri jockri deleted the override-pagepartwidget-template branch August 18, 2015 11:59
@roderik roderik modified the milestones: 3.2.5, 3.3.0 Aug 18, 2015
@tarjei
Copy link
Contributor

tarjei commented Sep 6, 2015

Simple question. If I understand this correctly, then this can be used to override the template shown in the Admin section of the site. What should I do in my code to use this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants