[NodeBundle] Fix page edit tab logic #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jockri
commented
Aug 20, 2015
jockri
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
- When you click on a tab, the url changes (?currenttab=menu) [new feature]
- When you have the tab in the url, the tab will be activated [this was broken]
- When you submit the form, when the page refreshes, the tab will be opened again [this was broken]
|
@diskwriter js,ok? |
| @@ -18,6 +21,44 @@ kunstmaanbundles.autoCollapseTabs = (function($, window, undefined) { | |||
| }); // when window is resized | |||
| }; | |||
|
|
|||
| initTabLogic = function () { | |||
| // If there is a tab defined in the url, we activate it | |||
| if ($('#currenttab') && $('#currenttab').val().length > 0) { | |||
There was a problem hiding this comment.
Maybe save $('#currenttab') to a var so it does not have to be re-selected all the time.
jockri
force-pushed
the
fix-page-edit-tab-logic
branch
from
75f7782
to
19ec3cd
Compare
|
I have added a check that |
roderik
pushed a commit
that referenced
this pull request
Aug 22, 2015
[NodeBundle] Fix page edit tab logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.