Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiDomainBundle] Added host aliases support #704

Merged
merged 1 commit into from
Sep 15, 2015

Conversation

yoshz
Copy link

@yoshz yoshz commented Sep 10, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets none

Added the ability to configure aliases for each host.
With this configuration each host can have multiple domain names without adding a new host configuration for each domain.

@denbatte
Copy link
Contributor

Hi @yoshz ,

Just a quick question: why would you define multiple aliases?
Could you explain your use case a bit more?

@yoshz
Copy link
Author

yoshz commented Sep 10, 2015

If you have multiple domains for the same site you only have to add an alias and avoid an extra site in the admin selector.
Users don't understand why a website is in the selector twice but uses the same page tree.

I currently use this functionality to add a test domainname alias next to the live domainname to a existing site.

@yoshz
Copy link
Author

yoshz commented Sep 11, 2015

I implemented a different way to solve our use case by overriding DomainConfiguration.
You still can merge this pull request if you think it usefull, otherwise you may close it.

@roderik
Copy link
Contributor

roderik commented Sep 12, 2015

@jockri this is the feature i was talking about :) I want this too :)

@jockri
Copy link
Contributor

jockri commented Sep 12, 2015

Looks like a good solution.
When you want different extra parameter values for each (aliased) domain, you can always define them separately.

@roderik
Copy link
Contributor

roderik commented Sep 14, 2015

@yoshz can you rebase your branch so i can merge this?

@roderik roderik added this to the 3.3.1 milestone Sep 15, 2015
roderik pushed a commit that referenced this pull request Sep 15, 2015
[MultiDomainBundle] Added host aliases support
@roderik roderik merged commit 7a52362 into Kunstmaan:master Sep 15, 2015
@dannyvw dannyvw deleted the feature/multidomain-aliases branch September 6, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants