[KunstmaanAdminBundle] Refactor DomainConfiguration #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finish refactoring fix documentation fix form types
roderik
changed the title
roderik
pushed a commit
that referenced
this pull request
Sep 24, 2015
[KunstmaanAdminBundle] Refactor DomainConfiguration
|
@wimvds I want to tag 3.4.0 but I need a UPGRADE-3.4.md file with the change to go from 3.3 to 3.4 in regards to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes projects that don't use the KunstmaanNodeBundle, so everything works for them as it should again. The DomainConfiguration had to be moved to KunstmaanAdminBundle, so this is a breaking change (it will only impact users that already used the domain configuration in their own projects though).
Upgrade instructions :
kunstmaan_node.domain_configurationwithkunstmaan_admin.domain_configurationKunstmaan\NodeBundle\Helper\DomainConfigurationInterfacewithKunstmaan\AdminBundle\Helper\DomainConfigurationInterface