Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminListBundle] Change image button image to icon #755

Merged
merged 2 commits into from
Oct 16, 2015
Merged

[AdminListBundle] Change image button image to icon #755

merged 2 commits into from
Oct 16, 2015

Conversation

aistis-
Copy link
Contributor

@aistis- aistis- commented Oct 14, 2015

Hello, I run into a problem. If I use list with configurator where I add buttons, they are printed different in edit page than in items list. I want them to look the same.

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no

@roderik
Copy link
Contributor

roderik commented Oct 15, 2015

@aistis- is this a breaking change?

also could you please include the table in your pull requests? It's documented in the contributing file

@aistis-
Copy link
Contributor Author

aistis- commented Oct 16, 2015

@roderik I guess it is BC for those who does not use crud table, but uses the buttons with with images

@aistis- aistis- changed the title Change image button image to icon [AdminListBundle] Change image button image to icon Oct 16, 2015
@roderik
Copy link
Contributor

roderik commented Oct 16, 2015

@aistis- add a small note to the Upgrade-3.4 file that mentions this for 3.4.1

@roderik roderik added this to the 3.4.1 milestone Oct 16, 2015
roderik pushed a commit that referenced this pull request Oct 16, 2015
[AdminListBundle] Change image button image to icon
@roderik roderik merged commit 577dcea into Kunstmaan:master Oct 16, 2015
@aistis-
Copy link
Contributor Author

aistis- commented Oct 16, 2015

@roderik I will do it next week :)

@aistis- aistis- deleted the patch-2 branch October 16, 2015 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants