[GeneratorBundle] Videopp adding compatibility for Vimeo and Dailymotion #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenonaitana
commented
Nov 13, 2015
morenonaitana
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
|
I think the placeholder image should come directly from the video provider as well? |
|
Yep, what Kevin said, the placeholder image should come from the video provider's api, unless the user specifies an image, in that case I think we can override it. |
|
The placeholder image from the video provider can be added in an other PR. |
jockri
pushed a commit
that referenced
this pull request
Dec 14, 2015
[GeneratorBundle] Videopp adding compatibility for Vimeo and Dailymotion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.