[AdminBundle] Dynamic reinit modules when a pagepart is added #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (modules) { | ||
| for (var i = 0; i < modules.length; i++) { | ||
| // Check if there really is a module with the given name and it if has a public reInit function | ||
| if (typeof kunstmaanbundles[modules[i]] !== 'undefined' && typeof kunstmaanbundles[modules[i]].reInit !== 'undefined') { |
There was a problem hiding this comment.
I would explicitly check for 'function' here.
|
Goed voor mij. Misschien nog een improvement voor in de toekomst, nu maak je op sommige plaatsen een identieke init en reInit functie aan. Misschien moet je kijken of er een reInit functie is en als deze er niet is, gewoon de init functie uitvoeren? Lijkt dit nog iemand een goed idee, of hoeft dat niet? |
|
@Sambego Zou dat precies willen vermijden vanwege risico dat je plugins gaat re-initializen die daar niet op voorzien zijn. |
|
ok |
jockri
pushed a commit
that referenced
this pull request
Dec 14, 2015
[AdminBundle] Dynamic reinit modules when a pagepart is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a new pagepart was added to a page, several javascript modules got reinitialised, even when they had nothing to do with this pagepart.
This feature makes it possible to just reinitialise one or more specific modules. This way, it is also possible to reinitialise modules which aren't default in the bundles.
This is an example of how you can trigger a reinitialise. Give the element a 'js-reinit' class and in the data attribute 'data-reinit-js' you can set the modules that need to be reinitialised for this pagepart.
It is important that the module has a public reInit function, because this is the function that will get triggered when the pagepart is added to the page.