[AdminBundle] Added up/down arrows on nested forms, fix rich editor when moving elements in DOM #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -293,6 +305,28 @@ kunstmaanbundles.pagepartEditor = function (window) { | |||
| cb({target: target}) | |||
| }) | |||
| }; | |||
| reInit = function($el) { | |||
| $($el).find('*[data-reinit-js]').each(function() { | |||
There was a problem hiding this comment.
$el is already a jQuery element here
…tmaanBundlesCMS into fix#adding-updown-nested
…tmaanBundlesCMS into fix#adding-updown-nested
|
@diskwriter good catch, done. |
jockri
pushed a commit
that referenced
this pull request
Jan 25, 2016
[AdminBundle] Added up/down arrows on nested forms, fix rich editor when moving elements in DOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested forms can now also be sorted by using the up and down arrow.
Also a fix for the rich editor. When moving a element around in the DOM by sorting it, the ckeditor gets disabled and the content is removed. This is a known bug in Ckeditor. I have fixed it by destroying all the rich editors and reinitialise them when moving them around.