[AdminListBundle, GeneratorBundle] add sortable option to entities #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sandergo90
commented
Feb 3, 2016
sandergo90
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #875 |
sandergo90
changed the title
| * @return string | ||
| */ | ||
| public function getSortableField() { | ||
|
|
There was a problem hiding this comment.
I would return null to make this more explicit
| $setter = "set".ucfirst($sortableField); | ||
| $getter = "get".ucfirst($sortableField); | ||
|
|
||
| $nextItem = $repo->createQueryBuilder('i')->where('i.'.$sortableField.' < :weight')->setParameter('weight', $item->getWeight())->orderBy('i.'.$sortableField, 'DESC')->setMaxResults(1)->getQuery()->getOneOrNullResult(); |
There was a problem hiding this comment.
getWeight can be other function name
[AdminListBundle]: move down action [AdminListBundle]: add sortable trait [AdminListBundle]: check for sortabletraits [GeneratorBundle]: add move up and down actions as example to bike entity [AdminListBundle]: remove sortable trait weight default value [WIP]: remove trait and update generator [GeneratorBundle, AdminBundle], add option sortable when generating adminlist [AdminListBundle]: remove first implementations [AdminListBundle]: set function names more dynamically
sandergo90
changed the title
jockri
pushed a commit
that referenced
this pull request
Feb 4, 2016
[AdminListBundle, GeneratorBundle] add sortable option to entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.