Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty password databases from KeepassX are not openable #2

Closed
anoadragon453 opened this issue Nov 26, 2017 · 10 comments
Closed

Empty password databases from KeepassX are not openable #2

anoadragon453 opened this issue Nov 26, 2017 · 10 comments

Comments

@anoadragon453
Copy link

If you attempt to create a database with an empty password, the app tells you off for it, but then goes ahead and makes the database anyways, which you then cannot open as you're not allowed to open a database without a password or keyfile.

IIRC Keypass does support creating and opening databases with a blank password and no keyfile, so ideally your app should allow users to open those databases.

Perhaps instead of preventing them from creating them with empty passphrases, stick a earning on screen that warns them that their data will not be secure, but allow them to create the database anyways.

@J-Jamet
Copy link
Member

J-Jamet commented Nov 26, 2017

Thanks for your return. I'll follow your advice, display a dialog and leave the possibility to open without password.

@J-Jamet
Copy link
Member

J-Jamet commented Dec 4, 2017

I added checkboxes to select password and / or keyfile and a dialog when there is an empty password.
Also a new screen for database creation.
I'll put the beta online in the week when I'll have finished the other developments and tested the code.

@anoadragon453
Copy link
Author

anoadragon453 commented Dec 4, 2017 via email

@J-Jamet
Copy link
Member

J-Jamet commented Dec 13, 2017

Done in 2.5.0.0beta3 but there are a new issue :

  • Empty password with checkbox checked in Keepass DX <=> Empty password with checkbox not checked in Keepass DX <=> Empty password whit checkbox not checked in KeepassX (Linux)
  • Empty password with checkbox checked in KeepassX (Linux) cannot be open yet in Keepass DX

It's a little more complicated to solve.

@anoadragon453
Copy link
Author

Ideally doing the same actions on each client would produce the same outcome. Is there any special reason KeepassX databases with empty passwords can't be opened yet in Keepass DX?

@J-Jamet
Copy link
Member

J-Jamet commented Dec 15, 2017

It's planed to have the same feature on both, but the methods of creating and opening by encryption must be refactored. I have to look exactly why.

@anoadragon453 anoadragon453 changed the title Attempting to create database with empty password shouldn't succeed Empty password databases from KeepassX are not openable Dec 15, 2017
@anoadragon453
Copy link
Author

Thanks for the info. To be honest it's not the biggest issue in the world right now, but definitely will be a blocker for a niche amount of users so should be fixed at some point :)

@J-Jamet
Copy link
Member

J-Jamet commented Dec 15, 2017

I understand, that's why I leave the issue open. I try to make the program as stable as possible according to user needs. ;)

@J-Jamet
Copy link
Member

J-Jamet commented Apr 25, 2018

Fixed in the new version 2.5.0.0beta9 ;)

@J-Jamet J-Jamet closed this as completed Apr 25, 2018
@anoadragon453
Copy link
Author

anoadragon453 commented Apr 25, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants