Skip to content
This repository has been archived by the owner on Sep 13, 2020. It is now read-only.

When using SideMenu, the ScrollView do not work #4

Closed
Iliker opened this issue Apr 21, 2015 · 12 comments · Fixed by #5
Closed

When using SideMenu, the ScrollView do not work #4

Iliker opened this issue Apr 21, 2015 · 12 comments · Fixed by #5

Comments

@Iliker
Copy link

Iliker commented Apr 21, 2015

<SideMenu menu={menu}>
  <Listview ...>
</SideMenu>

Look at the source code, onStartShouldSetPanResponder is true, so maybe scrollview cover.

Do not know how to solve the problem?

@Kureev Kureev mentioned this issue Apr 21, 2015
7 tasks
@chirag04
Copy link
Contributor

Interesting.

@Kureev This will be a tough problem to solve. onStartShouldSetPanResponder will not give scrollview a chance to scroll Unless we check if its a horizontal or vertical scroll.

@chirag04
Copy link
Contributor

@Kureev I think https://github.com/t4t5/react-native-router/blob/master/index.js#L62-L71 can help us.

what do you think?

chirag04 added a commit to chirag04/react-native-side-menu that referenced this issue Apr 21, 2015
@Kureev Kureev closed this as completed in #5 Apr 21, 2015
Kureev pushed a commit that referenced this issue Apr 21, 2015
handle horizontal swipe only. fixes #4
@chirag04
Copy link
Contributor

sweet! can you bump the version? Also, would you have time to document the openMenu externally?

It's been great working with you :)

@Kureev
Copy link
Owner

Kureev commented Apr 21, 2015

Done! 0.2.3 has been released!

@qingfeng
Copy link

🍺

@chirag04
Copy link
Contributor

Cheers! 🍺

@Kureev
Copy link
Owner

Kureev commented Apr 21, 2015

🍺

1 similar comment
@Iliker
Copy link
Author

Iliker commented Apr 22, 2015

🍺

@Kureev Kureev reopened this Apr 29, 2015
@Kureev
Copy link
Owner

Kureev commented Apr 29, 2015

I'm gonna to revert this commit. It should be done different way.

@Kureev Kureev closed this as completed in eb6c8f4 Apr 29, 2015
@Kureev
Copy link
Owner

Kureev commented Apr 29, 2015

I've updated an example in v0.2.4, so feel free to update your package and check an example with ScrollView + Navbar.

@chirag04
Copy link
Contributor

Kureev i added that because listView scroll was not working.

@Kureev
Copy link
Owner

Kureev commented May 2, 2015

Please, check 0.2.5. Looking forward for your feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants