iPad portrait

[jawadrehman]

I am having an issue with an iPad Air in portrait mode. It doesnt take the full height of the screen.

Have also tested using the example on here.

[Kureev]

Have you tried flex: 1 for your views? Do you have your View stretched correctly without side menu?
To give you more feedback, I need screenshot and version of react-native and plugin you're using.

[jawadrehman]

i have react native version 0.6, and the side menu version 0.9.0 .

I am sending pictures of how it looks like by just putting the menu item , or just putting the content.

flex : 1 is on all these components.

[jawadrehman]

@Kureev

[Kureev]

Wow, that's really weird, I'll take a look

[Kureev]

@alinz fyi, mb you have any thoughts so far?

[jawadrehman]

i have found a hackish solution around it.

i used react-native-device module, and set the height of the container view using the height provided and it seems to work. but it would be really helpful if its sorted out.

[Kureev]

so if the issue is in the wrong height of the wrapper element - it's good, I can manage it easily. Thanks for this feedback, it'll scope my research and save my time ;)

[Kureev]

@jawadrehman You know, I took a look on implementation, and honestly I don't like it (I mean react-native-device). I prefer that kind of check made on iOS part. There is a nice gist for that https://gist.github.com/Jaybles/1323251 and I think I gonna implement that in the nearest future and plug it in as a dependency for side menu. That would help I guess.

[jawadrehman]

but why would you need to set the height, isnt there a way of using flex to
do this ?

On Fri, Jul 10, 2015 at 1:04 PM, Alexey notifications@github.com wrote:

@jawadrehman https://github.com/jawadrehman You know, I took a look on
implementation, and honestly I don't like it (I mean react-native-device).
I prefer that kind of check made on iOS part. There is a nice gist for that
https://gist.github.com/Jaybles/1323251 and I think I gonna implement
that in the nearest future and plug it in as a dependency for side menu.
That would help I guess.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

[Kureev]

because we already use it https://github.com/Kureev/react-native-side-menu/blob/master/styles.js#L10 and it seems not working.

[Kureev]

@jawadrehman btw, are you sure your bottom menu haven't any weird paddingTop or something?

[jawadrehman]

" width: deviceScreen.width,height: deviceScreen.height, " whats that about
?

On Fri, Jul 10, 2015 at 1:19 PM, Alexey notifications@github.com wrote:

because we already use it
https://github.com/Kureev/react-native-side-menu/blob/master/styles.js#L10
and it seems not working.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

[jawadrehman]

I have tried the example code, without the tab bar and navbar and it still
has that padding left at the bottom .

On Fri, Jul 10, 2015 at 1:20 PM, Alexey notifications@github.com wrote:

@jawadrehman https://github.com/jawadrehman btw, are you sure your
bottom menu haven't any weird paddingTop or something?

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

[Kureev]

Yeah, that's weird. Maybe you're right about deviceScreen, until scroll it should works fine, but then it breaks, right? I'll try to fix it, but I can't use flex with position: absolute

[jawadrehman]

nah, it just has that padding as soon as the screen loads

On Fri, Jul 10, 2015 at 1:24 PM, Alexey notifications@github.com wrote:

Yeah, that's weird. Maybe you're right about deviceScreen, until scroll
it should works fine, but then it breaks, right?

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

[Kureev]

You know, I tried to run my example on iPad Portrait and wasn't able to reproduce it. I'm running react-native 0.7.1 and react-native-side-menu 0.9.5. Maybe update to latest version would solve your issue?

[Kureev]

@brentvatne

[Kureev]

probably the same as #82

[Kureev]

Ok, we're not supporting RN0.6 any more, I will reopen you'll be able to experience this with latest version.