This repository has been archived by the owner on Sep 13, 2020. It is now read-only.
Better handle gestures to open/close side menu #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…listview in the main view
|
Looks cool, thanks! I haven't time for making test now, but code looks correct. |
Kureev
pushed a commit
that referenced
this pull request
May 2, 2015
Better handle gestures to open/close side menu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the previous version of the code about gesture and just modify the accumulated distance of the gesture since the vertical touch started (
gestureState.dy).After some tests, I found out for a basic vertical swipe that the
dyvary between 0 and 10 (or -10 depending on the way you move your finger) .So I allow the absolute value of y to vary between 0 and 10.
I tried this change on listview in the main view and it seems to works even in the real IOS Device.