externalIpv4 and externalIpv6 affect all candidates instead of just host

[j1elo]

Prerequisites

These are MANDATORY, otherwise the issue will be automatically closed.

• I agree to fill this issue template.
• I have read the Troubleshooting Guide and Support Instructions.

Issue description

The addition of externalIpv4 and externalIpv6 to replace externalAddress lost the detail of affecting only the local candidates of type host. Using any of the newer parameters will change the address of ALL candidates, while using externalAddress would apply the given address only to host ones. So I guess this is a regression in behavior.

See screenshot, where externalIpv4 was set to 1.2.3.4:

Context

A Kurento server with externalIpv4 or externalIpv6 setting active, and also using a STUN or TURN server to retrieve srflx and relay candidates.

(Optional) Possible solution

Add

&& kms_ice_candidate_get_candidate_type (candidate) == KMS_ICE_CANDIDATE_TYPE_HOST)

to the conditionals, or move the conditionals inside a parent if () with mentioned code.

[github-actions]

Hello @j1elo! 👋 we're sorry you found a bug... so first of all, thank you very much for reporting it.

To know about progress, check in Triage. All issues are considered Backlog Candidates until work priorities align and the issue is selected for development. It will then become part of our official Backlog.