Use IceCandidateFound event instead of deprecated OnIceCandidate event - #9
Conversation
|
Hi there, thanks for your Pull Request! A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase |
|
Browser JS tutorials do not mention usage of There is a bunch of renames planned for Kurento 7, but for now this is a good first step in updating all client code. Thanks you! |
|
Thank you for acceptance :)
I see, and I'm sorry if it was ahead of the original plan. |
Well this PR is in line with the renaming that was on the line, but yes, it's better to first ask because otherwise you might do some work that in the end is not accepted because it conflicts with some other development or planning. But otherwise thanks for your interest in Kurento and your contributions! :) |
What is the current behavior you want to change?
Current code is using a event
OnIceCandidatethough the doc says it is deprecated:https://doc-kurento.readthedocs.io/en/stable/_static/client-jsdoc/module-elements.html#event:OnIceCandidate
What is the new behavior provided by this change?
Use
IceCandidateFoundevent instead as the doc says.How has this been tested?
I ran the tutorials.
Types of changes
Checklist